Reduce the RawStopTime size #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change unparsed enums from u32 to u16. This reduce the RawStopTime's size from 136 to 120. I think unparsed values are still quite high (and higher that 65536 will trigger an error on the row, so not a huge deal).
Tristramg
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change unparsed enums from u32 to u16.
This reduce the RawStopTime's size from 136 to 120.
I think unparsed values are still quite high (and higher that 65536 will trigger an error on the row, so not a huge deal).
On the FR IDF dataset, memory consumption goes from 3.9G to 3.4G.
Don't really know if the reduce value range is a problem on real datasets though